Skip to content

Fix debug symbols logic on platform=web to match Godot core. #1829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BenLubar
Copy link
Contributor

@BenLubar BenLubar commented Aug 9, 2025

Currently, building with platform=web debug_symbols=yes does not produce debug symbols.

@BenLubar BenLubar requested a review from a team as a code owner August 9, 2025 22:37
@BenLubar BenLubar changed the title Fix debug symbols logic on platform=web to match Godot core. Fix debug symbols logic on platform=web to match Godot core. Aug 9, 2025
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I haven't tested, but this matches what we have in Godot, so I think it should be good

@dsnopek dsnopek added bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup labels Aug 10, 2025
@dsnopek dsnopek added this to the 4.x milestone Aug 10, 2025
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 10, 2025

@enetheru What do we need to do (if anything) to do this for CMake as well?

@enetheru
Copy link
Collaborator

@enetheru What do we need to do (if anything) to do this for CMake as well?

@dsnopek
Nothing, CMake has its own mechanism for choosing to add the correct flags for debug symbols.
Either the variable CMAKE_BUILD_TYPE of either Debug or RelWithDebInfo for single configuration builders.
Or the --config option with the same values as above for multi-configuration builders.

@dsnopek
Copy link
Collaborator

dsnopek commented Aug 10, 2025

@enetheru Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants