Skip to content

Fix column wrong type caused by xorm #35141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 21, 2025

This PR upgrade xorm to v1.3.10 which fixed a bug when both longtext json tags in the struct field. The longtext will be ignored and json will be considered as text.

A migration has been introduced to modify the column directly to longtext.

Fix #34764

@lunny lunny added the type/bug label Jul 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 21, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 21, 2025
@hiifong
Copy link
Member

hiifong commented Jul 22, 2025

No sqlite support?

migration[321]: Fix review_state.updated_files column failed: near "MODIFY": syntax error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/dependencies modifies/go Pull requests that update Go code modifies/migrations type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Big PRs may reach the updated_files column max size
4 participants