Improve language in en-US locale strings #35124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
added 3 commits
July 19, 2025 12:36
- Use ellipsis consistently, replacing those instances where separate dot characters were used. Lead ellipsis with non-breaking space. In quoted code, separate dots are left in place, as ease of typing and identifying characters takes precedence over typography there. - Use periods instead of commas to separate sentences - Add commas where they aid parsing of a sentence - Add periods after sentences where neighboring sentences in the UI have one - Remove them where neighboring sentences in the UI don't have one - Use en dash instead of hyphen in range specifier - Use em dash instead of hyphen to separate summaries - Use apostrophe instead of quotation mark in possessives - Un-parenthesize where parentheses are not needed - Punctuate "e.g."
- Use "email address" consistently. Distinguish from "email" as a message for clarity. - Expand "pulls" to "pull requests" - Remove redundant sentence - Spell out "characters" - Change prepositions in some phrases for more idiomatic ones - Clarify sorting field being a range, not a boolean - Insert omitted words where they aid in parsing a sentence - Replace "refused" with "declined" which has less emotional weight - Replace "whilst" with the more commonly used "while" - Replace wordy expression: "currently" instead of "at this time" - Other replacements for more natural or common phrasing
lunny
approved these changes
Jul 19, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Jul 20, 2025
GiteaBot
added
lgtm/done
delvh
reviewed
Jul 20, 2025
Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Dominik Rubo <dr-1@posteo.net>
wxiaoguang
reviewed
Jul 21, 2025
delvh
reviewed
Jul 21, 2025
Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Dominik Rubo <dr-1@posteo.net>
Co-authored-by: delvh <dev.lh@web.de> Signed-off-by: Dominik Rubo <dr-1@posteo.net>
delvh
approved these changes
Jul 22, 2025
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35015
For easier review, the changes are split into separate commits by broad category. The extended commit messages include brief summaries. I am happy to make a separate pull request for each category if preferred.
While many of the changes are corrections, some are influenced by style. In those cases I have aimed mainly for consistency throughout the file, picking a style variant that I think is widely accepted and aids clarity.
There are additional things that could be improved that I have not touched. For example, contractions (phrasing variants such as "doesn't" vs. "does not") could be made more consistent. Not sure how colloquial or formal the maintainers would like the UI to be.