-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Add owner
and parent
fields clarification to docs
#35023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
211731c
to
0dec2d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks!
Most changes are: - // description: owner of the repo
+ // description: username of the user or organization owning the repository IMO "owner" is already a widely used concept, we can explain it somewhere, and keep the old description. Old description looks clearer |
714fcc9
to
7eb36d8
Compare
Thanks for reviewing the MR! :)
|
7eb36d8
to
04fde05
Compare
5ed304e
to
aadbc36
Compare
aadbc36
to
90e3f9f
Compare
Sure, your approach makes sense. I reverted the changes, could you please take another look? Could you please elaborate on the 'Concept' table in the UI? I don't understand where you'd like to put it (e.g. under the "This documentation describes the Gitea API" or outside of the API docs?). I'd be happy to write it if possible. |
Thank you very much. Will make some more changes, IMO:
|
Issue: #9637
Changes introduced: I have clarified the problematic terms (owner and parent) in all affected endpoints.
The changes were made to relevant:
This MR is big, but most changes are the same. If you'd like me to break this MR into several smaller ones, let me know :)