Fix environment variable mapping for read-only mode #1067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix environment variable mapping for read-only mode configuration
Add SetEnvKeyReplacer to viper configuration to properly map environment variables with underscores to flag names with dashes. This enables the documented GITHUB_READ_ONLY=1 environment variable to work correctly.
Without this fix, viper was looking for GITHUB_READ-ONLY (with dash) but the documentation and standard convention use GITHUB_READ_ONLY (with underscore).
Fixes issue where read-only mode was not being activated when using GITHUB_READ_ONLY=1 in Docker containers.
Incorrect Read-Only Tools when

GITHUB_READ_ONLY=1
passed:Test with

GITHUB_READ-ONLY=1
(Dash):Correct Result After The Patch:

go test -v ./...
golangci-lint run
script/lint
UPDATE_TOOLSNAPS=true go test ./...
script/generate-docs
Closes: