POtel implementation base branch #3152
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
potel-base
branch
2 times, most recently
from
f7f153c to
28effd6
Compare
sl0thentr0py
force-pushed
the
potel-base
branch
2 times, most recently
from
16f9341 to
951477f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
- Coverage 85.07% 85.02% -0.06%
==========================================
Files 156 158 +2
Lines 15824 15541 -283
Branches 2677 2461 -216
==========================================
- Hits 13462 13213 -249
+ Misses 1583 1572 -11
+ Partials 779 756 -23
|
szokeasaurusrex
force-pushed
the
potel-base
branch
from
d4b1d00 to
4428ee9
Compare
antonpirker
changed the title
* Make sure to add data before span is closed. some cleanup * Fixed some tests
* Make sure only spans are created, not transactions
* Move scope context init outside integration * Fix ThreadingIntegration by carrying forward span reference in (#3851) `use_scope` Since the otel context span reference is the source of truth for the current active span, we need to explicitly pass the span reference on the scope through when we use `use_scope` since we are changing context variables in the other thread. Also, * fixes some typing in the original scope * adds more types to the `contextvars_context` manager
This reverts commit 6d907a4.
Remove `MAX_EVENT_BYTES` (which doesn't seem to be used anyway?) Ref #4172
The migration guide was slowly becoming unreadable. It doesn't have to be as digestible as the migration guide in the docs, but it still shouldn't completely suck. Divide stuff into subsections and rephrase/expand on some points.
Ref #4641, for potel-base
Unsure if the types in `tests` are any good, but might as well make them into annotations
Merging `master` into `potel-base`, done in a PR because there have been some changes needed to the `span.name` setter to make it work for potel.
…4682) Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Seems like some `before_send`s out there might assume tags without safe access as we found out during dogfooding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
update_current_spanto SDK 3 #4679MAX_EVENT_BYTES#4630only_if_parenttoonly_as_child_span#4617scope.span =setter and make surescope.spanreference is correct in context manager regardless of source of span #4439SPANDATAconsistent in AI integrations.` #4376add_atttachment. #4360set_measurement#4333propagate_scope=FalseinThreadingIntegration#4310Scope.root_spanlogic #4274Scope.root_span#4273LoggingIntegrationto Sentry by default #4300integrations/opentelemetry/#4277integrations/opentelemetry/#4276integrations/opentelemetry/#4272integrations/opentelemetry/#4260integrations/opentelemetry/#4259integrations/opentelemetry/#4258cache_spansby default #3994start_spanfail if unsupported args are provided #4201Span.set_data()#4261sample_randto POTel #4106propagate_traces#4206warningsmodule for deprecation messagse. #4180sample_rateupdate topotel-base#4069SystemExit(0)not as a span status of 'internal_error' #4094use_scope#3851None#3816only_if_parentoption to POTelSpan and use it in integrations #3748_serialize_span_attributeintoset_attribute#3732subprocessbreadcrumbs frommaybe_create_breadcrumbs_from_spanto integration. #3637addto trace state if key does not exist #3645op. #3628make aws lambda layer#3586use_scope,use_isolation_scope#3522use_scope,use_isolation_scope#3500OpenTelemetryIntegrationtoDEFAULT_INTEGRATIONS#3471activeflag onPOTelSpan#3470start_transaction#3379Huband related code for good. #3446Simple test
References
startSpan& friendsstart_span& friendsMisc
In OTel, this:
is equivalent to