fix(browser): Use current start timestamp for CLS span when CLS is 0 #17800
+239
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the title
Lms24
commented
Sep 26, 2025
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser.cls', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'ui.webvital.cls', | ||
| [SEMANTIC_ATTRIBUTE_EXCLUSIVE_TIME]: entry?.duration || 0, | ||
| [SEMANTIC_ATTRIBUTE_EXCLUSIVE_TIME]: 0, |
There was a problem hiding this comment.
those were just useless bytes. duration is always zero for CLS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no layout shift, the standalone CLS span would previously have the same start time as the pageload span (
performance.timeOrigin). This caused the cls span to be incorrectly interpreted as the trace root in the Sentry UI. We can fix this by setting the span start timestamp as the startTime instead if there's no layout shift. In all other cases, we let the span start at the time the last CLS update occured.