Fix Familiars prepping REs that affect the canvas on game load #19344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17182
Core issue: Familiars skip RE prepping if they don't have a master but due to timing, no familiar has a master on the first run of data prep when the world is loading. The master does trigger a reset and reload of their Familiar before the canvas is shown, but it happens after everything is loaded and can't render REs that impact the canvas.
Certain REs, to appear when the canvas is ready, need to be prepped beforehand. This impacts TokenLight and Aura at least.
REs that rely on the master will fail validation on load with a warning but immediately be re-prepped by the master-triggered reset and reload.