Remove check for old braavos accounts (#3558)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #

## Introduced changes

Thanks to some adjustments, all braavos accounts (old and new) should
work

https://swmansion.slack.com/archives/C05U5MZ2RPE/p1752062824037899?thread_ts=1752062411.210489&cid=C05U5MZ2RPE

## Checklist

<!-- Make sure all of these are complete -->

- [ ] Linked relevant issue
- [ ] Updated relevant documentation
- [ ] Added relevant tests
- [ ] Performed self-review of the code
- [ ] Added changes to `CHANGELOG.md`

Author: franciszekjob

CHANGELOG.md

@@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `ready` option for `--type` flag in `account create` and `account import` commands (Argent wallet has rebranded as Ready)
 
+#### Changed
+
+- Braavos accounts with all class hashes are now supported 
+
 #### Deprecated
 
 - `argent` option for `--type` flag in `account create` and `account import` commands. Use `ready` instead

crates/sncast/src/helpers/braavos.rs

@@ -1,4 +1,3 @@
-use anyhow::{Error, bail};
 use async_trait::async_trait;
 use starknet::{
     accounts::{AccountFactory, PreparedAccountDeploymentV3, RawAccountDeploymentV3},
@@ -9,8 +8,6 @@ use starknet::{
 use starknet_crypto::poseidon_hash_many;
 use starknet_types_core::felt::Felt;
 
-use super::constants::BRAAVOS_OLD_CLASS_HASHES;
-
 // Adapted from strakli as there is currently no implementation of braavos account factory in starknet-rs
 pub struct BraavosAccountFactory<S, P> {
     class_hash: Felt,
@@ -143,13 +140,3 @@ where
             .is_interactive(SignerInteractivityContext::Other)
     }
 }
-
-pub fn check_braavos_account_compatibility(class_hash: Felt) -> Result<(), Error> {
-    let msg = "Using incompatible Braavos accounts is disabled because they don't work with starknet >= 0.13.4.
-    Visit this link to read more: https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3";
-
-    if BRAAVOS_OLD_CLASS_HASHES.contains(&class_hash) {
-        bail!(msg)
-    }
-    Ok(())
-}

crates/sncast/src/helpers/constants.rs

@@ -28,11 +28,6 @@ pub const BRAAVOS_CLASS_HASH: Felt =
 pub const BRAAVOS_BASE_ACCOUNT_CLASS_HASH: Felt =
     felt!("0x03d16c7a9a60b0593bd202f660a28c5d76e0403601d9ccc7e4fa253b6a70c201"); // v1.2.0
 
-pub const BRAAVOS_OLD_CLASS_HASHES: &[Felt] = &[
-    felt!("0x02c8c7e6fbcfb3e8e15a46648e8914c6aa1fc506fc1e7fb3d1e19630716174bc"),
-    felt!("0x041bf1e71792aecb9df3e9d04e1540091c5e13122a731e02bec588f71dc1a5c3"),
-];
-
 // used in wait_for_tx. Txs will be fetched every 5s with timeout of 300s - so 60 attempts
 pub const WAIT_TIMEOUT: u16 = 300;
 pub const WAIT_RETRY_INTERVAL: u8 = 5;

crates/sncast/src/lib.rs

@@ -5,7 +5,6 @@ use camino::Utf8PathBuf;
 use clap::ValueEnum;
 use conversions::serde::serialize::CairoSerialize;
 use foundry_ui::UI;
-use helpers::braavos::check_braavos_account_compatibility;
 use helpers::constants::{KEYSTORE_PASSWORD_ENV_VAR, UDC_ADDRESS};
 use rand::RngCore;
 use rand::rngs::OsRng;
@@ -257,13 +256,6 @@ pub async fn get_account<'a>(
     } else {
         get_account_data_from_accounts_file(account, chain_id, accounts_file)?
     };
-
-    // Braavos accounts before v1.2.0 are not compatible with starknet >= 0.13.4
-    // For more, read https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
-    if let Some(class_hash) = account_data.class_hash {
-        check_braavos_account_compatibility(class_hash)?;
-    }
-
     let account = build_account(account_data, chain_id, provider).await?;
 
     Ok(account)

crates/sncast/src/starknet_commands/account/create.rs

@@ -10,7 +10,7 @@ use conversions::IntoConv;
 use foundry_ui::UI;
 use foundry_ui::components::warning::WarningMessage;
 use serde_json::json;
-use sncast::helpers::braavos::{BraavosAccountFactory, check_braavos_account_compatibility};
+use sncast::helpers::braavos::BraavosAccountFactory;
 use sncast::helpers::constants::{
     BRAAVOS_BASE_ACCOUNT_CLASS_HASH, BRAAVOS_CLASS_HASH, CREATE_KEYSTORE_PASSWORD_ENV_VAR,
     OZ_CLASS_HASH, READY_CLASS_HASH,
@@ -75,12 +75,6 @@ pub async fn create(
         ui.print_blank_line();
     }
 
-    // Braavos accounts before v1.2.0 are not compatible with starknet >= 0.13.4
-    // For more, read https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
-    if let Some(class_hash) = create.class_hash {
-        check_braavos_account_compatibility(class_hash)?;
-    }
-
     let salt = extract_or_generate_salt(create.salt);
     let class_hash = create.class_hash.unwrap_or(match create.account_type {
         AccountType::OpenZeppelin => OZ_CLASS_HASH,

crates/sncast/src/starknet_commands/account/import.rs

@@ -12,7 +12,6 @@ use foundry_ui::UI;
 use foundry_ui::components::warning::WarningMessage;
 use sncast::check_if_legacy_contract;
 use sncast::helpers::account::generate_account_name;
-use sncast::helpers::braavos::check_braavos_account_compatibility;
 use sncast::helpers::rpc::RpcArgs;
 use sncast::response::account::import::AccountImportResponse;
 use sncast::{AccountType, check_class_hash_exists, get_chain_id, handle_rpc_error};
@@ -80,12 +79,6 @@ pub async fn import(
         ui.print_blank_line();
     }
 
-    // Braavos accounts before v1.2.0 are not compatible with Starknet >= 0.13.4
-    // For more, read https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
-    if let Some(class_hash) = import.class_hash {
-        check_braavos_account_compatibility(class_hash)?;
-    }
-
     let private_key = if let Some(passed_private_key) = &import.private_key {
         passed_private_key
     } else if let Some(passed_private_key_file_path) = &import.private_key_file_path {

crates/sncast/tests/e2e/account/create.rs

@@ -903,42 +903,6 @@ fn get_keystore_account_pattern(account_type: AccountType, class_hash: Option<&s
     to_string_pretty(&account_json).unwrap()
 }
 
-#[test_case("0x02c8c7e6fbcfb3e8e15a46648e8914c6aa1fc506fc1e7fb3d1e19630716174bc"; "braavos_v1_1_0")]
-#[test_case("0x041bf1e71792aecb9df3e9d04e1540091c5e13122a731e02bec588f71dc1a5c3"; "braavos_v1_0_0")]
-fn test_old_braavos_class_hashes_disabled(class_hash: &str) {
-    let temp_dir = tempdir().expect("Unable to create a temporary directory");
-    let accounts_file = "accounts.json";
-
-    let args = vec![
-        "--accounts-file",
-        accounts_file,
-        "account",
-        "create",
-        "--url",
-        URL,
-        "--name",
-        "my_account",
-        "--salt",
-        "0x1",
-        "--class-hash",
-        class_hash,
-        "--type",
-        "braavos",
-    ];
-
-    let snapbox = runner(&args).current_dir(temp_dir.path());
-    let output = snapbox.assert().success();
-
-    assert_stderr_contains(
-        output,
-        indoc! {r"
-        Command: account create
-        Error: Using incompatible Braavos accounts is disabled because they don't work with starknet >= 0.13.4.
-            Visit this link to read more: https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
-        "},
-    );
-}
-
 #[tokio::test]
 pub async fn test_happy_case_deployment_fee_message() {
     let tempdir = tempdir().expect("Failed to create a temporary directory");