Rename argent to ready (#3504)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #3501 

## Introduced changes

Rename argent to ready, due to their rebranding.

Add `ready` option and deprecates existing `argent`. Fore sncast
accounts json, we use `ready`, but still accept `argent` for backward
compatibility. When saving account to starkli format, `ready` is mapped
to `argent` (because starkli doesn't support `ready` yet).

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`

Author: franciszekjob

CHANGELOG.md

@@ -13,6 +13,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Passing a cheatcode span of 0 was incorrectly treated as `CheatSpan::Indefinite`. This is now resolved by making `CheatSpan::TargetCalls` accept `NonZero<usize>` instead of just `usize` in `snforge_std`.
 
+### Cast
+
+#### Added
+
+- `ready` option for `--type` flag in `account create` and `account import` commands (Argent wallet has rebranded as Ready)
+
+#### Deprecated
+
+- `argent` option for `--type` flag in `account create` and `account import` commands. Use `ready` instead
+
 ## [0.46.0] - 2025-07-09
 
 ### Forge

crates/cheatnet/src/runtime_extensions/call_to_blockifier_runtime_extension/execution/entry_point.rs

@@ -135,7 +135,7 @@ pub fn execute_call_entry_point(
         .set_class_hash_for_current_call(class_hash);
     // endregion
 
-    // Hack to prevent version 0 attack on argent accounts.
+    // Hack to prevent version 0 attack on ready (formerly argent) accounts.
     if context.tx_context.tx_info.version() == TransactionVersion(Felt::from(0_u8))
         && class_hash
             == TryFromHexStr::try_from_hex_str(FAULTY_CLASS_HASH)

crates/sncast/src/helpers/constants.rs

@@ -19,7 +19,7 @@ pub const UDC_ADDRESS: Felt =
     felt!("0x041a78e741e5af2fec34b695679bc6891742439f7afb8484ecd7766661ad02bf");
 pub const OZ_CLASS_HASH: Felt =
     felt!("0x05b4b537eaa2399e3aa99c4e2e0208ebd6c71bc1467938cd52c798c601e43564"); // v1.0.0
-pub const ARGENT_CLASS_HASH: Felt =
+pub const READY_CLASS_HASH: Felt =
     felt!("0x036078334509b514626504edc9fb252328d1a240e4e948bef8d0c08dff45927f"); // v0.4.0
 
 pub const BRAAVOS_CLASS_HASH: Felt =

crates/sncast/src/lib.rs

@@ -56,6 +56,7 @@ pub enum AccountType {
     #[serde(rename = "open_zeppelin")]
     OpenZeppelin,
     Argent,
+    Ready,
     Braavos,
 }
 
@@ -66,6 +67,7 @@ impl FromStr for AccountType {
         match s {
             "open_zeppelin" | "open-zeppelin" | "oz" => Ok(AccountType::OpenZeppelin),
             "argent" => Ok(AccountType::Argent),
+            "ready" => Ok(AccountType::Ready),
             "braavos" => Ok(AccountType::Braavos),
             account_type => Err(anyhow!("Invalid account type = {account_type}")),
         }
@@ -385,7 +387,7 @@ pub fn get_account_data_from_keystore(
         .and_then(|account_type| account_type.parse().ok());
 
     let public_key = match account_type.context("Failed to get type key")? {
-        AccountType::Argent => parse_to_felt("/variant/owner"),
+        AccountType::Argent | AccountType::Ready => parse_to_felt("/variant/owner"),
         AccountType::OpenZeppelin => parse_to_felt("/variant/public_key"),
         AccountType::Braavos => get_braavos_account_public_key(&account_info)?,
     }

crates/sncast/src/starknet_commands/account/create.rs

@@ -7,11 +7,13 @@ use camino::Utf8PathBuf;
 use clap::Args;
 use console::style;
 use conversions::IntoConv;
+use foundry_ui::UI;
+use foundry_ui::components::warning::WarningMessage;
 use serde_json::json;
 use sncast::helpers::braavos::{BraavosAccountFactory, check_braavos_account_compatibility};
 use sncast::helpers::constants::{
-    ARGENT_CLASS_HASH, BRAAVOS_BASE_ACCOUNT_CLASS_HASH, BRAAVOS_CLASS_HASH,
-    CREATE_KEYSTORE_PASSWORD_ENV_VAR, OZ_CLASS_HASH,
+    BRAAVOS_BASE_ACCOUNT_CLASS_HASH, BRAAVOS_CLASS_HASH, CREATE_KEYSTORE_PASSWORD_ENV_VAR,
+    OZ_CLASS_HASH, READY_CLASS_HASH,
 };
 use sncast::helpers::rpc::RpcArgs;
 use sncast::response::account::create::AccountCreateResponse;
@@ -63,7 +65,16 @@ pub async fn create(
     provider: &JsonRpcClient<HttpTransport>,
     chain_id: Felt,
     create: &Create,
+    ui: &UI,
 ) -> Result<AccountCreateResponse> {
+    // TODO(#3556): Remove this warning once we drop Argent account type
+    if create.account_type == AccountType::Argent {
+        ui.println(&WarningMessage::new(
+            "Argent has rebranded as Ready. The `argent` option for the `--type` flag in `account create` is deprecated, please use `ready` instead.",
+        ));
+        ui.print_blank_line();
+    }
+
     // Braavos accounts before v1.2.0 are not compatible with starknet >= 0.13.4
     // For more, read https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
     if let Some(class_hash) = create.class_hash {
@@ -73,7 +84,7 @@ pub async fn create(
     let salt = extract_or_generate_salt(create.salt);
     let class_hash = create.class_hash.unwrap_or(match create.account_type {
         AccountType::OpenZeppelin => OZ_CLASS_HASH,
-        AccountType::Argent => ARGENT_CLASS_HASH,
+        AccountType::Argent | AccountType::Ready => READY_CLASS_HASH,
         AccountType::Braavos => BRAAVOS_CLASS_HASH,
     });
     check_class_hash_exists(provider, class_hash).await?;
@@ -171,7 +182,7 @@ async fn generate_account(
                 OpenZeppelinAccountFactory::new(class_hash, chain_id, signer, provider).await?;
             get_address_and_deployment_fee(factory, salt).await?
         }
-        AccountType::Argent => {
+        AccountType::Argent | AccountType::Ready => {
             let factory =
                 ArgentAccountFactory::new(class_hash, chain_id, None, signer, provider).await?;
 
@@ -268,11 +279,12 @@ fn create_to_keystore(
                 }
             })
         }
-        AccountType::Argent => {
+        AccountType::Argent | AccountType::Ready => {
             json!({
                 "version": 1,
                 "variant": {
-                    "type": AccountType::Argent,
+                    // TODO(#3556): Remove hardcoded "argent" and use format! with `AccountType::Ready`
+                    "type": "argent",
                     "version": 1,
                     "owner": format!("{:#x}", private_key.verifying_key().scalar()),
                     "guardian": "0x0",

crates/sncast/src/starknet_commands/account/deploy.rs

@@ -208,7 +208,7 @@ async fn get_deployment_result(
     ui: &UI,
 ) -> Result<InvokeResponse> {
     match account_type {
-        AccountType::Argent => {
+        AccountType::Argent | AccountType::Ready => {
             let factory = ArgentAccountFactory::new(
                 class_hash,
                 chain_id,
@@ -392,7 +392,7 @@ pub(crate) fn compute_account_address(
     chain_id: Felt,
 ) -> Felt {
     match account_type {
-        AccountType::Argent => get_contract_address(
+        AccountType::Argent | AccountType::Ready => get_contract_address(
             salt,
             class_hash,
             &[private_key.verifying_key().scalar(), Felt::ZERO],

crates/sncast/src/starknet_commands/account/import.rs

@@ -8,6 +8,8 @@ use anyhow::{Context, Result, bail, ensure};
 use camino::Utf8PathBuf;
 use clap::Args;
 use conversions::string::{TryFromDecStr, TryFromHexStr};
+use foundry_ui::UI;
+use foundry_ui::components::warning::WarningMessage;
 use sncast::check_if_legacy_contract;
 use sncast::helpers::account::generate_account_name;
 use sncast::helpers::braavos::check_braavos_account_compatibility;
@@ -68,7 +70,16 @@ pub async fn import(
     accounts_file: &Utf8PathBuf,
     provider: &JsonRpcClient<HttpTransport>,
     import: &Import,
+    ui: &UI,
 ) -> Result<AccountImportResponse> {
+    // TODO(#3556): Remove this warning once we drop Argent account type
+    if import.account_type == AccountType::Argent {
+        ui.println(&WarningMessage::new(
+                "Argent has rebranded as Ready. The `argent` option for the `--type` flag in `account import` is deprecated, please use `ready` instead.",
+            ));
+        ui.print_blank_line();
+    }
+
     // Braavos accounts before v1.2.0 are not compatible with Starknet >= 0.13.4
     // For more, read https://community.starknet.io/t/starknet-devtools-for-0-13-5/115495#p-2359168-braavos-compatibility-issues-3
     if let Some(class_hash) = import.class_hash {

crates/sncast/src/starknet_commands/account/list.rs

@@ -114,7 +114,13 @@ impl Message for AccountDataRepresentationMessage {
             let _ = writeln!(result, "  legacy: {legacy}");
         }
         if let Some(ref account_type) = self.account_type {
-            let _ = writeln!(result, "  type: {account_type}");
+            // TODO(#3556): Remove this adjustment when the `argent` account type is removed
+            let displayed_type = if account_type == &AccountType::Argent {
+                &AccountType::Ready
+            } else {
+                account_type
+            };
+            let _ = writeln!(result, "  type: {displayed_type:?}");
         }
 
         result.trim_end().to_string()

crates/sncast/src/starknet_commands/account/mod.rs

@@ -57,11 +57,16 @@ pub fn prepare_account_json(
     class_hash: Option<Felt>,
     salt: Option<Felt>,
 ) -> serde_json::Value {
+    // TODO(#3556): Once `Argent` variant is deleted, use `account_type` directly
+    let saved_account_type = match account_type {
+        AccountType::Argent => AccountType::Ready,
+        _ => account_type,
+    };
     let mut account_json = json!({
         "private_key": format!("{:#x}", private_key.secret_scalar()),
         "public_key": format!("{:#x}", private_key.verifying_key().scalar()),
         "address": format!("{address:#x}"),
-        "type": format!("{account_type}").to_lowercase().replace("openzeppelin", "open_zeppelin"),
+        "type": format!("{saved_account_type}").to_lowercase().replace("openzeppelin", "open_zeppelin"),
         "deployed": deployed,
         "legacy": legacy,
     });
@@ -209,6 +214,7 @@ pub async fn account(
                 &config.accounts_file,
                 &provider,
                 &import,
+                ui,
             )
             .await;
 
@@ -248,6 +254,7 @@ pub async fn account(
                 &provider,
                 chain_id,
                 &create,
+                ui,
             )
             .await;
 

crates/sncast/tests/data/accounts/accounts.json

@@ -112,13 +112,14 @@
             "salt": "0xe35eea9d1b0fa729",
             "legacy": true
         },
-        "argent": {
+        "ready": {
             "address": "0x0321dd5ed1ff8ca08792d5c7c66d9daad1f0249c4defbe045b28ab0fec1beaed",
             "class_hash": "0x36078334509b514626504edc9fb252328d1a240e4e948bef8d0c08dff45927f",
             "legacy": false,
             "private_key": "0x00bb17245c662eb6ada1ae85c0a6afc77b0df2aa92ee9046e577f4427cdf6d3a",
             "public_key": "0x04d2c00e488819b43a09d720694fe97aa44054803f411bdc93d6b22d548f69a2",
-            "salt": "0x50d1de0aa965925d611a0d52142f22f6fd0a664838b213da4621f8d70230b40"
+            "salt": "0x50d1de0aa965925d611a0d52142f22f6fd0a664838b213da4621f8d70230b40",
+            "type": "ready"
         },
         "braavos": {
             "address": "0x2235bf96ef3f88915e3537f9a692977f5caf10b728dd95b0a3ccca2282fbb9b",