Skip to content

Conversation

@edvinolo
Copy link
Contributor

Remove the use stdlib_linalg_iterative_solvers statement in the iterative solver implementation submodules. The use statement is not needed since a submodule has access to its parent module via host association. There is also a paragraph in the standard that might disallow this, see e.g. the discussion here: llvm/llvm-project#169863. Flang gives an error for these lines, although apparently not gfortran or ifx.

Along the same lines, the submodules also contain use statements that are already present in the parent module and should therefore be redundant; these could also be removed if you agree.

(@jalvesz @jvdp1 since you have worked on the iterative solvers)

Remove the use stdlib_linalg_iterative_solvers statement in the solver
implementation submodules.
@jalvesz jalvesz changed the title Remove parent module use statement in iterative solver submodules fix: remove parent module use statement in iterative solver submodules Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.69%. Comparing base (34723c7) to head (45b4825).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   68.69%   68.69%           
=======================================
  Files         392      392           
  Lines       12693    12693           
  Branches     1377     1377           
=======================================
  Hits         8720     8720           
  Misses       3973     3973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant