Skip to content

Conversation

trueqbit
Copy link
Collaborator

While working on sql views, I came across some parts that I thought would be worth generalizing and streamlining the code base before making other, more profound changes.

In this PR:

  • Removed superfluous serializer_context_builder.
  • Renamed serializer context flag variables - e.g. omitting column types with the fts5_column flag will be needed for views as well.
  • Encapsulated logging executes SQL statements in all locations, while step functions are kept in their respective functions for greater clarity.
  • Select statements and "raw" DML (Data Modification Language) statements are now treated uniformly, regardless of whether they are used directly or embedded as the main statement in a With clause.
  • Used c_str() instead of data() to more clearly express the intent where it makes sense.p
  • Simplified code involving column filters with a new alias template.
  • Renamed storage_t<>::sync_table() -> storage_t<>::sync_dbo() as this method is overloaded for all possible database object types.

`c_str()` expresses intent better than `data()`
Also increased unit test coverage.
... while step functions are kept in their respective functions for greater clarity.
* Removed `serializer_context_builder`, which is now entirely replaced by `obtain_db_objects()`.
* Renamed serializer context flag variables.
@trueqbit trueqbit requested a review from fnc12 September 26, 2025 19:07
@trueqbit trueqbit merged commit e809bbc into dev Sep 27, 2025
4 checks passed
@trueqbit trueqbit deleted the generalize branch September 27, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants