Generalize and streamline code base #1455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on sql views, I came across some parts that I thought would be worth generalizing and streamlining the code base before making other, more profound changes.
In this PR:
serializer_context_builder
.fts5_column
flag will be needed for views as well.c_str()
instead ofdata()
to more clearly express the intent where it makes sense.pstorage_t<>::sync_table()
->storage_t<>::sync_dbo()
as this method is overloaded for all possible database object types.