Pci cleanup #5453
Draft
Pci cleanup #5453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't really use the programming interface field of the PCI header. It's always zero for the devices we support. Don't expose it as an argument for constructing PciConfiguration objects. Signed-off-by: Babis Chalios <bchalios@amazon.es>
Drop PciBarConfiguration type which wasn't used anywhere any more. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
pci_cleanup
branch
from
63788e4 to
1d5c3d0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
==========================================
+ Coverage 82.78% 82.80% +0.01%
==========================================
Files 263 263
Lines 27292 27261 -31
==========================================
- Hits 22594 22573 -21
+ Misses 4698 4688 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The implementation of the PCI emulation components is heavily Firecracker opinionated. Move those inside a module of `vmm` crate and leave in the `pci` module only type definitions which can easily be reused across VMMs. We also take advantage of this refactoring to remove in various places the usage of `std::io::Error` as error types returned by emulation logic. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
pci_cleanup
branch
from
1d5c3d0 to
72b76f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.