-
Notifications
You must be signed in to change notification settings - Fork 169
feat: option to start a local docker registry #1601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
superewald
wants to merge
5
commits into
firecow:master
Choose a base branch
from
superewald:docker-registry
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
987e19e
feat: option to start local docker registry
superewald 2eaff16
fix linting errors
superewald 8f84b33
fix already exist check for container errors
superewald 55765a4
run oci test container in privileged mode
superewald d3679eb
fix $CI_REGISTRY[..] variable scopes
superewald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
registry-variables: | ||
image: alpine:latest | ||
script: | ||
- echo "CI_REGISTRY=$CI_REGISTRY" | ||
- echo "CI_REGISTRY_USER=$CI_REGISTRY_USER" | ||
- echo "CI_REGISTRY_PASSWORD=$CI_REGISTRY_PASSWORD" | ||
|
||
registry-login-docker: | ||
image: docker:dind | ||
script: | ||
- echo "$CI_REGISTRY_PASSWORD" | docker login -u $CI_REGISTRY_USER --password-stdin $CI_REGISTRY | ||
|
||
registry-login-oci: | ||
image: quay.io/podman/stable | ||
script: | ||
- echo "$CI_REGISTRY_PASSWORD" | podman login -u $CI_REGISTRY_USER --password-stdin $CI_REGISTRY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import {WriteStreamsMock} from "../../../src/write-streams.js"; | ||
import {handler} from "../../../src/handler.js"; | ||
import {Utils} from "../../../src/utils.js"; | ||
import chalk from "chalk"; | ||
|
||
test("local-registry ci variables", async () => { | ||
const writeStreams = new WriteStreamsMock; | ||
await handler({ | ||
cwd: "tests/test-cases/local-registry", | ||
job: ["registry-variables"], | ||
registry: true, | ||
}, writeStreams); | ||
|
||
const expected = [ | ||
chalk`{blueBright registry-variables} {greenBright >} CI_REGISTRY=${Utils.gclRegistryPrefix}`, | ||
chalk`{blueBright registry-variables} {greenBright >} CI_REGISTRY_USER=${Utils.gclRegistryPrefix}.user`, | ||
chalk`{blueBright registry-variables} {greenBright >} CI_REGISTRY_PASSWORD=${Utils.gclRegistryPrefix}.password`, | ||
]; | ||
|
||
expect(writeStreams.stdoutLines).toEqual(expect.arrayContaining(expected)); | ||
}); | ||
|
||
test("local-registry login <docker>", async () => { | ||
const writeStreams = new WriteStreamsMock(); | ||
await handler({ | ||
cwd: "tests/test-cases/local-registry", | ||
job: ["registry-login-docker"], | ||
registry: true, | ||
}, writeStreams); | ||
|
||
|
||
const expected = [ | ||
chalk`{blueBright registry-login-docker} {greenBright >} Login Succeeded`, | ||
]; | ||
|
||
expect(writeStreams.stdoutLines).toEqual(expect.arrayContaining(expected)); | ||
}); | ||
|
||
test("local-registry login <oci>", async () => { | ||
const writeStreams = new WriteStreamsMock(); | ||
await handler({ | ||
cwd: "tests/test-cases/local-registry", | ||
job: ["registry-login-oci"], | ||
registry: true, | ||
privileged: true, | ||
}, writeStreams); | ||
|
||
|
||
const expected = [ | ||
chalk`{blueBright registry-login-oci} {greenBright >} Login Succeeded!`, | ||
]; | ||
|
||
expect(writeStreams.stdoutLines).toEqual(expect.arrayContaining(expected)); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@superewald Without a wait-for-port you risk jobs start pushing to the registry before it is ready.