-
Notifications
You must be signed in to change notification settings - Fork 50
[Firebase AI] Improve Live API FunctionCalling #1308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've enhanced the Live API's function calling capabilities within Firebase AI. This involves introducing specific logic within the LiveSession
to handle function responses, ensuring they are correctly formatted and sent. Additionally, I've incorporated an Id
field into both the function call and function response structures, which will improve the system's ability to track and correlate these interactions.
Highlights
- Live API Function Response Handling: Implemented dedicated logic in LiveSession.cs to correctly serialize and send FunctionResponseParts as toolResponse objects, ensuring proper communication with the Live API.
- Function Call/Response ID Integration: Added an Id property to both FunctionCallPart and FunctionResponsePart in ModelContent.cs, allowing for better tracking and correlation of function calls and their corresponding responses.
- API Surface Update: Modified the ModelContent.FunctionResponse static method to accept the new optional id parameter, reflecting the updated data model.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enhances function calling capabilities for the Live API by introducing an Id
to FunctionCallPart
and FunctionResponsePart
for better correlation. It also adds logic to LiveSession
to handle sending FunctionResponsePart
as a distinct toolResponse
. My feedback focuses on improving code clarity and ensuring consistent serialization behavior.
Description
Add special logic to handle Live API Function responses. Add the Id to the Function Call logic.
Testing
Testing locally.
Type of Change
Place an
x
the applicable box: