Skip to content

[Firebase AI] Add thought summary and signature support #9192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewheard
Copy link

@andrewheard andrewheard commented Aug 1, 2025

WIP - Added support for including thought summaries and thought signatures.

Manually tested through the quickstart but still needs unit tests and deciding if the approach in getText makes sense. Chat handling will also need to be implemented.

Copy link

changeset-bot bot commented Aug 1, 2025

⚠️ No Changeset found

Latest commit: e8df63d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andrewheard
Copy link
Author

cc: @dlarocque

export function getText(response: GenerateContentResponse): string {
export function getText(
response: GenerateContentResponse,
isThought: boolean
Copy link
Contributor

@hsubox76 hsubox76 Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of passing a specific boolean for thoughts we pass through a filter function here:

partFilter: () => boolean

and then when we call it in addHelpers() above it's like getText(response, (part) => !part.thought) for text() and it's getText(response, (part) => part.thought) for thoughtSummary(). And then in the condition below it's if (part.text && partFilter(part))

This makes it read clearly when it's called (or we can just add a comment before true and false). It might get unwieldy if we have other kinds of text parts in the future that have more complex logic though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants