Firebase AI Hybrid Inference Implementation #9029
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
dlarocque
reviewed
Jul 31, 2025
Comment on lines
51
to
57
| constructor( | ||
| apiSettings: ApiSettings, | ||
| public model: string, | ||
| private chromeAdapter?: ChromeAdapter, | ||
| public params?: StartChatParams, | ||
| public requestOptions?: RequestOptions | ||
| ) { |
There was a problem hiding this comment.
This is a breaking change for users who pass params or requestOptions. Could we make this a non-breaking change by moving chromeAdapter to be the last parameter?
There was a problem hiding this comment.
Users aren't supposed to instantiate ChatSession directly, they are supposed to call startChat, which doesn't have ordered params and actually doesn't allow passing requestOptions at all. I wanted to actually stop exporting ChatSession for that reason, but that would be a breaking change.
There was a problem hiding this comment.
Our documentation doesn't state that users shouldn't use the ChatSession constructor so I feel we should try our best to avoid breaking it outside of a breaking release.
I think we should continue to export the ChatSession class, but in the next breaking release maybe we should make the constructor internal if we don't want users to create it.
dlarocque
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains implementation & docs for hybrid inference.
API Proposal (internal doc): https://docs.google.com/document/d/1gBlTkMABfjsCre9g5jMfN2DrMV6isql43mFg58V9PkQ/edit?tab=t.0#heading=h.jsemgbpc5x7
Notes
ChromeAdapteris an internal class the user should not call but it's passed to the constructor ofChatSessionwhich is publicly exported, so it needs to be exported. I created aChromeAdapterinterface that reflects the public methods of that class so it can be used as a type, without exporting the whole class.Documentation
This also contains some fixes to documentation in other sections of the AI SDK (missing beta flag on an Imagen symbol, fixed some links).
The hybrid inference feature is experimental and we don't have automated doc tooling to handle that case (currently
@betatags become labeled "(Public Preview)") so for now I have manually put "(EXPERIMENTAL)" on all the new features.