feat: Core: FirebaseAuthUI Singleton & DI #2215
Merged
+501
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lyokone
commented
Sep 15, 2025
Lyokone
commented
- Add FirebaseAuthUI class with getInstance() methods and internal caching
- Support for default app via getInstance() with singleton pattern
- Support for multiple Firebase apps via getInstance(app)
- Add create(app, auth) for custom auth injection and multi-tenancy
- Thread-safe implementation using ConcurrentHashMap
- Comprehensive unit tests covering all singleton behaviors
- Tests verify caching, multi-app support, and custom auth injection
demolaf
reviewed
Sep 15, 2025
auth/src/test/java/com/firebase/ui/auth/compose/FirebaseAuthUITest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.