Fixing some bugs in example feature repo for spark #5407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creating parquet files with timestamps in us units instead of ns (pyspark has problems reading ns timestamps) - removing on-the-fly features that aren't declared before - settings join keys for entities. Signed-off-by: Felix-neko <felix-neko@list.ru>
| @@ -109,8 +107,6 @@ def fetch_online_features(store, use_feature_service: bool): | |||
| features_to_fetch = [ | |||
| "driver_hourly_stats:acc_rate", | |||
| "driver_hourly_stats:avg_daily_trips", | |||
| "transformed_conv_rate:conv_rate_plus_val1", | |||
There was a problem hiding this comment.
Oh these didn't work?
There was a problem hiding this comment.
This on-the-fly feature was not declared in the example feature repo for Spark and i have just removed it from this example.
There was a problem hiding this comment.
Looking at the code under aws/feature_repo/example_repo.py had this ODFV:
# Define an on demand feature view which can generate new features based on
# existing feature views and RequestSource features
@on_demand_feature_view(
sources=[driver_stats_fv, input_request],
schema=[
Field(name="conv_rate_plus_val1", dtype=Float64),
Field(name="conv_rate_plus_val2", dtype=Float64),
],
)
def transformed_conv_rate(inputs: pd.DataFrame) -> pd.DataFrame:
df = pd.DataFrame()
df["conv_rate_plus_val1"] = inputs["conv_rate"] + inputs["val_to_add"]
df["conv_rate_plus_val2"] = inputs["conv_rate"] + inputs["val_to_add_2"]
return dfThere was a problem hiding this comment.
Great, it works. I've restored it.
…ving unimplemented part with stream data pushing). Signed-off-by: Felix-neko <felix-neko@list.ru>
Signed-off-by: Felix-neko <felix-neko@list.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
I've just tried to do
feast init -t sparkand to run generatedtest_workflow.py(Python 3.11, PySpark 3.5, OS Ubuntu 24.04).There were some errors that I was able to fix, maybe it will be helpful.