-
-
Notifications
You must be signed in to change notification settings - Fork 75
feat: Add Bun and Deno to typescript support check #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 4 commits
5a6d882
5489d2c
150fafa
d51ddea
a90cd47
ed71226
d574640
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -21,3 +21,31 @@ jobs: | |||
with: | ||||
license-check: true | ||||
lint: true | ||||
bun: | ||||
runs-on: ubuntu-latest | ||||
continue-on-error: true | ||||
steps: | ||||
- uses: actions/checkout@v4 | ||||
Codex- marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
with: | ||||
persist-credentials: false | ||||
|
||||
- name: Setup Bun | ||||
uses: oven-sh/setup-bun@v2 | ||||
|
||||
- name: Install dependencies | ||||
# The erraneous typod version `5.0.0-aplha` takes priority over .3 as 'p' > 'l' | ||||
run: | | ||||
bun i --ignore-scripts | ||||
bun i -D --ignore-scripts fastify@5.0.0-alpha.3 | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not ideal The typod version seems to be unpublished now — can't find it at https://www.npmjs.com/package/fastify?activeTab=versions Can you try removing the line?
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm sorry but I don't understand why this is needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because of the typo in the version name bun takes
Can be removed once beta has begun There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can confirm this is the case |
||||
|
||||
- name: Run types check | ||||
run: bun run typescript | ||||
|
||||
- name: Run Jest tests | ||||
run: bun run typescript:jest | ||||
|
||||
- name: Run Vitest tests | ||||
run: bun run typescript:vitest | ||||
|
||||
- name: Run unit tests | ||||
run: bun run unit:bun |
Uh oh!
There was an error while loading. Please reload this page.