Add search functionality to items endpoint with tests #1715
+117
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaswanthrajeev, thank you for the interest in project! Do you have plans to continue working on this? |
| assert response.status_code == 200 | ||
| content = response.json() | ||
| assert content["count"] == 1 | ||
| assert content["data"][0]["title"] == "Alpha Item" |
There was a problem hiding this comment.
Maybe also assert that item2 is NOT returned, just to be explicit about the filtering.
youneshenniwrites
suggested changes
Sep 13, 2025
| assert response.status_code == 200 | ||
| content = response.json() | ||
| assert content["count"] == 2 | ||
| assert len(content["data"]) == 2 |
There was a problem hiding this comment.
Maybe also assert the titles of the returned items (e.g., "Test Item 1" and "Test Item 2") so the test is stronger and doesn’t rely on implicit ordering.
|
This pull request has a merge conflict that needs to be resolved. |
github-actions
bot
added
the
conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Search Functionality to Items API
Summary
searchquery parameter to the/api/v1/items/endpoint.How to Test