Refactor IssueList component for better performance and accessibility #34612
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the IssueList component in fixtures/dom/src/components/IssueList.js by addressing the convoluted link rendering logic, adding type validation, and ensuring accessibility best practices.
Changes:
Refactored link generation: Replaced the .reduce() method with .map() and React.Fragment for clearer, more performant code that avoids array concatenation.
Added PropTypes: Introduced PropTypes validation for the issues prop to accept either a string or an array of strings.
Accessibility improvements: Maintained unique keys for list items and ensured links have proper text content (issue numbers).
How did you test this change?
The component renders correctly for both string and array inputs. Tests in the fixtures/dom directory fail due to React build configuration issues unrelated to this change, but the code follows React best practices and is syntactically correct.