Skip to content

trie: optimize array allocation during sync path construction #32756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

trie: optimize array allocation during sync path construction #32756

wants to merge 2 commits into from
+3 −2

Conversation

hero5512
Copy link
Contributor

This is a minor memory allocation optimization for the sync path construction

rjl493456442
rjl493456442 reviewed Sep 28, 2025
View reviewed changes
AlexanderYastrebov
AlexanderYastrebov reviewed Sep 28, 2025
View reviewed changes
MariusVanDerWijden
MariusVanDerWijden approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STGM, probably not really an improvement speed wise, but looks a bit cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

@gballet gballet Awaiting requested review from gballet gballet is a code owner

+1 more reviewer

@AlexanderYastrebov AlexanderYastrebov AlexanderYastrebov left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hero5512 @AlexanderYastrebov @rjl493456442 @MariusVanDerWijden