eth/fetcher: improve the condition to stall peer in tx fetcher #32725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
reviewed
Sep 25, 2025
| if otherreject > int64(len(batch)/4) { | ||
| time.Sleep(200 * time.Millisecond) | ||
| log.Debug("Peer delivering stale transactions", "peer", peer, "rejected", otherreject) | ||
| log.Debug("Peer delivering invalid transactions", "peer", peer, "rejected", otherreject) |
There was a problem hiding this comment.
Should this log be before the sleep?
|
The new condition will cause a peer to sleep if they send a batch with 1 invalid tx. The stall is still quite short, so doesn't seem like an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.