Skip to content

CHANGELOG(3.4,3.5,3.6): Add update in docs of --quota-backend-bytes #20381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025

Conversation

4rivappa
Copy link
Contributor

Source PR: #20328

Issue: #20224

@k8s-ci-robot
Copy link

Hi @4rivappa. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jul 22, 2025

/ok-to-test

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@7137745). Learn more about missing BASE report.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20381   +/-   ##
=======================================
  Coverage        ?   69.16%           
=======================================
  Files           ?      415           
  Lines           ?    34630           
  Branches        ?        0           
=======================================
  Hits            ?    23952           
  Misses          ?     9288           
  Partials        ?     1390           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7137745...336ce41. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr
Copy link
Member

ahrtr commented Jul 22, 2025

/retest

@ivanvc
Copy link
Member

ivanvc commented Jul 23, 2025

@4rivappa could you please rebase your branch? We released 3.5.22 and 3.6.3 earlier today, and the CHANGELOG has changed since. Note that your changes should still be under 3.5.22 and 3.6.3.

Thanks

Signed-off-by: arivappa <4rivappa@proton.me>
@4rivappa 4rivappa reopened this Jul 23, 2025
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & thx

@ahrtr ahrtr merged commit f79fc2c into etcd-io:main Jul 23, 2025
33 checks passed
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 4rivappa, ahrtr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants