fix(blank/unique): add default handling for blank=True field
#9751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Shishov <sshishov.sshishov@gmail.com>
sshishov
force-pushed
the
ss/fix/allow-blank-unique-constraint
branch
from
3bcd191 to
8de6a6c
Compare
|
I have added tests similar to the tests added in #9531 |
deepakangadi
suggested changes
Aug 5, 2025
| class Meta: | ||
| constraints = [ | ||
| # Unique constraint on 2 blank fields | ||
| models.UniqueConstraint(name='unique_constraint', fields=('age', 'tag'), condition=~models.Q(models.Q(title='') & models.Q(tag='True'))) |
There was a problem hiding this comment.
Don't we have a char length limit here?
|
|
||
| def test_blank_uqnique_constraint_fields_are_not_required(self): | ||
| serializer = UniqueConstraintBlankSerializer(data={'age': 25}) | ||
| self.assertTrue(serializer.is_valid(), serializer.errors) |
There was a problem hiding this comment.
Can we split it into multiple assertions?
| ids_in_qs = {frozenset(v.queryset.values_list(flat=True)) for v in validators if hasattr(v, "queryset")} | ||
| assert ids_in_qs == {frozenset([1]), frozenset([3])} | ||
|
|
||
| def test_blank_uqnique_constraint_fields_are_not_required(self): |
|
Hi @sshishov @auvipy @deepakangadi, I can help unblock this by:
If this sounds good, I can start working on these changes. Should I update this branch (if permitted) or create a new PR? Thanks for your guidance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR should fix the issue with
blank=Truefield inUniqueTogetherconstraint. It should not become required all of a sudden.Fixes #9750