Extract GraphQL activation modes to defcustom #4877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extracts hardcoded major modes for GraphQL LSP activation into a customizable variable, improving configuration flexibility while maintaining backward compatibility.
- Introduces
lsp-graphql-activated-modesdefcustom to replace hardcoded mode list - Updates activation logic to use the configurable variable instead of fixed mode names
- Preserves existing default behavior with js-mode, js2-mode, typescript-mode, and typescript-ts-mode
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Make the list of major modes that can activate the GraphQL language server configurable via `lsp-graphql-activated-modes` custom variable. This allows users to extend or modify which modes can trigger GraphQL LSP activation without modifying the source code. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
suzuki
force-pushed
the
extract-lsp-graphql-modes-to-defcustom
branch
from
d095b25 to
15edabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lsp-graphql-activated-modesMotivation
I wanted to disable lsp-graphql activation in typescript-ts-mode but there was no way to do it. The major modes were hardcoded in the activation function. This change makes it easier for users to control which modes activate the GraphQL language server by providing a customizable variable.
Changes
lsp-graphql-activated-modeswith the list of major modeslsp-graphql-activate-pto use the customizable list viaapply