-
Notifications
You must be signed in to change notification settings - Fork 1k
POC end datetime #8515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
POC end datetime #8515
Conversation
|
High level it looks good! Have a question about changing the dict key from |
|
I didn't implement it (yet) but that should be possible with the pydantic validators in the base parser classes. That particular change in the datetime to a tuple is just in the internal representation of the entsoe data in this specific parser. The output would be a plain dict/json where the key is called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces support for an optional datetime_end field in production, exchange, and price data structures across the electricitymap parsers. The field is set to None by default for existing data points, allowing for future representation of time intervals rather than point-in-time measurements.
Key Changes
- Added
datetime_endfield to data point structures (production, exchange, price) - Updated test snapshots to include
datetime_end: Nonefor all existing test cases - Modified TAIPOWER parser to use keyword arguments for clarity
Reviewed changes
Copilot reviewed 42 out of 60 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| electricitymap/contrib/parsers/TAIPOWER.py | Updated production_breakdown.append() to use explicit keyword arguments |
| Multiple test snapshot files | Added datetime_end: None field to all test data points for production, exchange, and price data |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 42 out of 60 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Already had some quick changes for ENTSO-E production so I could determine the scope of this.
Figured I might as well put it here for you guys to have a look at.
Output would be: