Skip to content

[23531] Add --quiet to git submodule invocations (backport #5944) #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 21, 2025

Description

When forcing third-party usage with -DTHIRPARTY_xxx=FORCE, the Fast DDS build succeeds but leaves traces from the progress of git submodule update commands in stderr.

This PR fixes that by leveraging the --quiet option, so only error messages are printed to stderr.

@Mergifyio backport 3.3.x 3.2.x 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #5944 done by [Mergify](https://mergify.com).

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 921ca34)
@MiguelCompany MiguelCompany added this to the v3.3.1 milestone Jul 21, 2025
@MiguelCompany MiguelCompany self-requested a review July 21, 2025 13:03
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 21, 2025
@MiguelCompany MiguelCompany merged commit 62eb3b4 into 3.3.x Jul 22, 2025
25 of 27 checks passed
@MiguelCompany MiguelCompany deleted the mergify/bp/3.3.x/pr-5944 branch July 22, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant