feat: allow optionally ignoring specific paths #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Nathanael Ruf <nathanael-ruf@users.noreply.github.com>
e-dant
reviewed
May 26, 2025
|
Overall this looks good. I do worry about incompatibilities between platforms, and other platform-dependent behavior, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have only tried this using inotify and nodejs, but it seems to work and is very useful in my case.
There are probably lot's of things missing to make this work with other backends and tests, but i don't know this watcher or c well enough to do that properly.
If
FAN_MARK_FILESYSTEMis going to be supported in the future, then filtering paths has to be done differently for that as well.