check onUpdateFn result for updates #4663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclarson
reviewed
Jul 4, 2025
drizzle-orm/src/gel-core/dialect.ts
Outdated
| @@ -149,7 +149,11 @@ export class GelDialect { | |||
| return sql.join(columnNames.flatMap((colName, i) => { | |||
| const col = tableColumns[colName]!; | |||
|
|
|||
| const value = set[colName] ?? sql.param(col.onUpdateFn!(), col); | |||
| let value = set[colName]; | |||
| if (!value) { | |||
There was a problem hiding this comment.
this check should be value === undefined (across all dialects)
check onUpdateFn result type within buildUpdateSet/buildUpdateQuery the same way it was done in buildInsertQuery in case of SQL returned directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check onUpdateFn result type within buildUpdateSet/buildUpdateQuery the same way it was done in buildInsertQuery in case of SQL returned directly