Re-Enable OTEL #4643
Open
Re-Enable OTEL #4643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-Enable OTEL as since 2023 support for top-level await has become quite common. And at least in my debugging of the built output, this is the only thing stopping OTEL integration for drizzle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTEL was disabled in 2023 due to requiring a top-level await. This PR seeks to re-introduce OTEL on an opt-in basis (by installing to '@opentelemetry/api` package) with a console error for the rare misconfigured imports if the module is found so that it does not fail silently.
For more context see issue #371, commit 5279a7b and PR #664