Skip to content

Conversation

Eazash
Copy link

@Eazash Eazash commented Sep 3, 2025

Description

This PR moves writing the profiler output to the exit process event. This is to ensure both single-pass and watch mode consistently write the profiler file as the event will be fired on explicit process.exit() or any unhandled exceptions

Related #10382

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

I had explored using the shutdown method of the watcher but I was unable to reliably trigger that method as the SIGINT and SIGTERM event listeners weren't being called when stopping the watcher with CTRL + C or an explicit SIGINT signal with kill. I plan to further explore this in the future but this was why I opted to use the exit event

Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: b4440df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant