-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
docs: update sidebar link formatting #2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the root cause may be the styling since the display:none
apply to all the non a
elements.
As a single line in _sidebar.md
, which does't as a group but a link, we need reconsider how to structure the sidebar and refine the css selector.
docsify/src/themes/shared/_sidebar.css
Line 91 in be21637
&.collapse { |
&.collapse {
> :not(a) {
display: none;
}
}
|
Summary
There are some issues with clicking on awesome and changelog. https://preview.docsifyjs.org/#/awesome
The solution is to remove the p tag from the top level
<li><p><a></a></p></li>
.Related issue, if any:
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change?
Yes
Tested in the following browsers: