Add Docker Support #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebuild every time configuration is changed
…ebuild every time configuration is changed
|
Hello @RossIV, Happy New Year and many thanks for your pull request. Awesome work! 👏 Based on feedback #2 here, I've already made significant changes to the code (e.g. moving out credentials part and much more) which will be released in Q1 this year. Docker support has already been considered, as the "one file for all" concept doesn't seem to appeal to everyone. If you have any other suggestions for improvements that you would like to see in version 2, please let me know. Keep up the good work! Thank you, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to run this (awesome!) tool in Docker, which saves the effort of having to manually install PHP, php-snmp, net-snmp-utils, and your web server daemon of choice.
The most notable change is the re-location of the PDU configuration from
index.phpinto a standaloneconfig.phpfile. Sinceindex.phpgets copied into the image at build time, with the configuration values inside that file it's not possible to make any changes without rebuilding the image. Havingconfig.phpmounted as a volume (viadocker compose) allows it to be updated as needed whileindex.phpremains static in the image. I've done my best to updateREADME.mdaccordingly for this.