Skip to content

feat: Add dfx binaries for aarch64-darwin. #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 25, 2025
Merged

Conversation

vincent-dfinity
Copy link
Contributor

@vincent-dfinity vincent-dfinity commented Jun 16, 2025

Description

Add dfx binaries for aarch64-darwin.

  1. Extend build.rs and dfx-asset-sources.json to support aarch64-darwin.
  2. Extend update-motoko.sh and update-replica.sh to support aarch64-darwin.
  3. Update GitHub checks to support aarch64-darwin, use macos-13-xlarge for macOS 13 Arm64 according to this document.
  4. For now, the pocket-ic download URLs are different for aarch64 without using the gz format; we have to work around this on our side.
  5. I'll update the dfxvm side once we have a public release on the dfx side.

Fixes # (issue)

SDK-1462

How Has This Been Tested?

The current GitHub checks are extended to cover aarch64-darwin.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vincent-dfinity vincent-dfinity marked this pull request as ready for review June 23, 2025 04:37
@vincent-dfinity vincent-dfinity requested a review from a team as a code owner June 23, 2025 04:37
@vincent-dfinity
Copy link
Contributor Author

I'm not quite confident that I covered all the necessary places in the GitHub workflows, especially for the publish.yml. Could someone familiar with this area take a look as well? Thanks.

@vincent-dfinity vincent-dfinity enabled auto-merge (squash) June 25, 2025 00:47
@vincent-dfinity vincent-dfinity merged commit d02e30a into master Jun 25, 2025
120 checks passed
@vincent-dfinity vincent-dfinity deleted the vincent/SDK-1462 branch June 25, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants