Skip to content

refactor(frontend): Use generic transactions store interface in ETH transactions store #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AntonioVentilii
Copy link
Collaborator

Motivation

It makes sense to use the generic transactions store in the Ethereum transaction store initializer, to avoid repetition of code.

@AntonioVentilii AntonioVentilii marked this pull request as ready for review July 21, 2025 14:45
@AntonioVentilii AntonioVentilii requested a review from a team as a code owner July 21, 2025 14:45
Copy link
Contributor

@roman-nazaruk roman-nazaruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thnx

@AntonioVentilii AntonioVentilii enabled auto-merge (squash) July 22, 2025 10:47
@AntonioVentilii AntonioVentilii merged commit 85c7425 into main Jul 22, 2025
56 checks passed
@AntonioVentilii AntonioVentilii deleted the refactor(frontend)/Use-generic-transactions-store-interface-in-ETH-transactions-store branch July 22, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants