Skip to content

feat(projects): separate projects tables by type #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 18, 2025

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Jul 15, 2025

Motivation

The Tokens and Neurons tables will be divided into multiple tables to distinguish ICP from other assets. This PR separates the Neurons table into distinct tables for each type: NNS and SNS neurons. The SNS neuron table will be hidden if the user has no neurons and has selected the hide 0 balance toggle. Additionally, we want to display a different table for those SNS projects that have been sunset.

Mobile Desktop
Screenshot 2025-07-17 at 15 58 15 Screenshot 2025-07-17 at 15 58 02
Screenshot 2025-07-17 at 17 23 44 Screenshot 2025-07-17 at 17 23 21

NNS1-3966

Changes

  • Split the current Projects table into three instances: nns, sns and sunset sns.

Tests

Todos

  • Accessibility (a11y) – any impact?
  • Changelog – is it needed?

@yhabib yhabib force-pushed the nns1-3966/split-neurons-page branch 2 times, most recently from bb14301 to 5217775 Compare July 17, 2025 13:31
@yhabib yhabib changed the title split neurons feat(projects): separate projects tables by category Jul 17, 2025
@yhabib yhabib changed the title feat(projects): separate projects tables by category feat(projects): separate projects tables by type Jul 17, 2025
@yhabib yhabib force-pushed the nns1-3966/split-neurons-page branch 2 times, most recently from d430666 to 5acd376 Compare July 17, 2025 14:46
@yhabib yhabib marked this pull request as ready for review July 17, 2025 15:14
@yhabib yhabib requested a review from a team as a code owner July 17, 2025 15:14
@yhabib yhabib force-pushed the nns1-3966/split-neurons-page branch from 08eaf90 to 64e3f24 Compare July 17, 2025 15:25
@yhabib yhabib force-pushed the nns1-3966/split-neurons-page branch from 207c964 to 804fd45 Compare July 17, 2025 21:23
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yhabib yhabib enabled auto-merge July 18, 2025 06:15
@yhabib yhabib added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit d847d8b Jul 18, 2025
36 checks passed
@yhabib yhabib deleted the nns1-3966/split-neurons-page branch July 18, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants