chore: track mainnet cycles ledger index canister #5927
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team.
Therefore, make sure that you have done the following (for
Governance-owned code):
-
Add entry(s) to corresponding
unreleased_changelog.md
file(s). This is only necessary if the code changes result in
externally visible behavior changes. -
If there are behavior changes, are they breaking? This is
usually due to some new requirement(s) imposed by the canister,
or removal of guarantees supplied by the canister. If the
changes are breaking, are your clients ready for them? If not,
put your changes behind a "feature flag". If you have a feature
flag, then, do NOT add entrie(s) tounreleased_changelog.md
in this PR, but rather, do that later when you set the flag to
"enable" in another PR. -
Is data migration needed? (If so, make sure it is part of this
PR.) -
Does this require security review? At the very least, you can
tell security team about this PR, and let them decide whether
the risk warrants their review.
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, look
for where it says this bot is requesting changes, click the three
dots on the right, select "Dismiss review", and for each of the
numbered items listed above, supply one of the following reasons:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
To be more precise, "externally visible behavior change" usually
means that responses differ in some way. However, "externally
visible behavior change" is not limited to that. For example, it
could also means that the canister makes different requests to
other canisters.
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
mraszyk
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
| @@ -76,6 +77,7 @@ canisters( | |||
| "ck_eth_ledger_v2_noledgerversion": "mainnet_cketh_ic-icrc1-ledger-u256-v2-noledgerversion", | |||
| "ck_eth_ledger_v3": "mainnet_cketh_ic-icrc1-ledger-u256-v3", | |||
| "ck_eth_index": "mainnet_cketh-index-ng", | |||
| "cycles_ledger_index": "mainnet_cycles_ledger_index", | |||
There was a problem hiding this comment.
The actual canister file name is ic-icrc1-index-ng-u256.wasm.gz (i.e., ng as well as u256), but why would we add such a suffix given that there's only a single cycles ledger index deployed?
This PR adds the cycles ledger index canister to be tracked as a mainnet canister with its version automatically bumped after upgrades on the ICP mainnet.