Skip to content

update multimodal intro notebook for 2.16 release #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

update multimodal intro notebook for 2.16 release #248

merged 3 commits into from
Jul 29, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jul 28, 2025 •
edited
Loading

  • updated installation command and imports
  • removed mentions to the experimental nature of the components
  • removed the multimodal RAG Pipeline example: it had a bad user experience and the upcoming notebook by Seb with the new components is way better in this regard

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@anakin87 anakin87 requested a review from bilgeyucel July 28, 2025 10:51
bilgeyucel
bilgeyucel reviewed Jul 28, 2025
View reviewed changes
notebooks/multimodal_intro.ipynb
@@ -8,7 +8,7 @@
"source": [
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this info note here


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

bilgeyucel
bilgeyucel approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one small comment, thanks @anakin87!

@bilgeyucel bilgeyucel marked this pull request as ready for review July 28, 2025 13:26
@bilgeyucel bilgeyucel requested a review from a team as a code owner July 28, 2025 13:26
@bilgeyucel bilgeyucel merged commit 04485b4 into main Jul 29, 2025
1 check passed
@bilgeyucel bilgeyucel deleted the update-multimodal-notebook branch July 29, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgeyucel bilgeyucel bilgeyucel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @bilgeyucel