Skip to content

Remove unreferenced blas_connector.h header #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Cstandardlib
Copy link
Collaborator

@Cstandardlib Cstandardlib commented Jul 20, 2025

Remove unreferenced source_base/module_external/blas_connector.h header, including:

  • source_hsolver
  • source_lcao/module_gint
  • source_lcao/module_ri
  • source_lcao/module_operator_lcao
  • source_lcao/module_lr
  • source_pw/module_stodft
  • source_pw/pwdft

Also notice that Header in source_base are moved to the cpp file that actually use it instead of an .h.

I recommend that header files are only included where they are actually used. This will:

  1. Reduce Compilation Dependencies
  2. Avoid Namespace Pollution. Public headers should only expose necessary declarations. BLAS symbols (e.g., function names, macros) would otherwise leak into the global namespace, risking conflicts with other libraries.
  3. Maintain Clean Public Interfaces

source_lcao/module_deepks is left unchanged.

@Cstandardlib Cstandardlib marked this pull request as ready for review July 20, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant