Allow faraday client configuration #138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -202,6 +203,7 @@ def for_uri(uri, extra_headers = {}) | |||
| extra_headers.each do |key, value| | |||
| faraday.headers[key] = value | |||
| end | |||
| @faraday_configurer.call(faraday) if @faraday_configurer | |||
There was a problem hiding this comment.
Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
| @@ -12,10 +12,11 @@ class FCM | |||
| INSTANCE_ID_API = "https://iid.googleapis.com" | |||
| TOPIC_REGEX = /[a-zA-Z0-9\-_.~%]+/ | |||
|
|
|||
| def initialize(json_key_path = "", project_name = "", http_options = {}) | |||
| def initialize(json_key_path = "", project_name = "", http_options = {}, faraday_configurer = nil) | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [100/80]
|
@sabman can you take a look at this? |
|
Just need to add a test - are you able to do that? |
srook
force-pushed
the
customize-faraday-client
branch
from
6c1ed78 to
6c647c3
Compare
srook
force-pushed
the
customize-faraday-client
branch
from
6c647c3 to
efcc76a
Compare
srook
force-pushed
the
customize-faraday-client
branch
from
efcc76a to
94e5da6
Compare
sure. test added, please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable additional configuration of Faraday client, allowing usage of different Faraday middleware.
This PR also partially resolves #59, as it allows configuring retry middleware.