Skip to content

Handle PermisssionDenied exception so that a new dashboard is created. #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025

Conversation

pritishpai
Copy link
Contributor

Changes

Integration test for invalid dashboard is failining on PermissionDenied which we currently do not handle. Add a handler for PermissionDenied so that the older one is ignored and a new dashboard is creted.

Linked issues

Resolves #4208

Functionality

  • handle older dangling dashboard

Tests

  • existing test

@pritishpai pritishpai requested a review from a team as a code owner July 11, 2025 14:46
Copy link

github-actions bot commented Jul 11, 2025

✅ 24/24 passed, 1 skipped, 41m17s total

Running from acceptance #8688

@pritishpai pritishpai requested a review from asnare July 11, 2025 15:08
Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: only a few nits, but nothing that blocks merging.

@asnare asnare added the bug label Jul 11, 2025
@asnare asnare added this to UCX Jul 11, 2025
@asnare asnare moved this to Ready for Review in UCX Jul 11, 2025
@pritishpai pritishpai added this pull request to the merge queue Jul 11, 2025
Merged via the queue into main with commit 9157b72 Jul 11, 2025
8 checks passed
@pritishpai pritishpai deleted the fix/invalid_dashboard_test branch July 11, 2025 16:03
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Jul 11, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jul 11, 2025
Quick PR to fix some nits that were missed from PR from
#4209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Test failure: test_installation_when_dashboard_id_is_invalid[01ef4d7b294112968fa07ffae17dd55f]
2 participants