Skip to content

Update integration test to use make_random() properly #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

asnare
Copy link
Contributor

@asnare asnare commented Jun 30, 2025

Changes

This PR updates a test that was using the make_random fixture incorrectly: instead of calling the function and using the result, it was passing the function itself.

Tests

  • updated integration test

@asnare asnare self-assigned this Jun 30, 2025
@asnare asnare requested a review from a team as a code owner June 30, 2025 14:34
@asnare asnare added internal this pull request won't appear in release notes bug labels Jun 30, 2025
@asnare asnare added this to UCX Jun 30, 2025
@asnare asnare temporarily deployed to account-admin June 30, 2025 14:34 — with GitHub Actions Inactive
@asnare asnare moved this to Ready for Review in UCX Jun 30, 2025
Copy link

✅ 46/46 passed, 5 skipped, 7h15m14s total

Running from acceptance #8663

@pritishpai pritishpai added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 14c8223 Jun 30, 2025
8 checks passed
@pritishpai pritishpai deleted the fix-make-random branch June 30, 2025 16:08
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug internal this pull request won't appear in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants