Skip to content

Added force_refresh parameter for Assessment #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Added force_refresh parameter for Assessment #4183

wants to merge 18 commits into from

Conversation

pritishpai
Copy link
Contributor

@pritishpai pritishpai commented Jun 25, 2025 •
edited
Loading

Changes

Added a parameter to the assessment job allowing users to force a complete refresh of the assessment data

Resolves #4184

Functionality

  • added relevant user documentation

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • verified on staging environment (screenshot attached)

@pritishpai pritishpai requested a review from a team as a code owner June 25, 2025 14:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2025 •
edited
Loading

✅ 56/56 passed, 1 flaky, 9 skipped, 45m38s total

Flaky tests:

  • 🤪 test_new_collection (39.666s)

Running from acceptance #8720

@pritishpai pritishpai changed the title Full refresh all crawlers for each assessment run Added force_refresh parameter for Assessment Jun 26, 2025
@gueniai gueniai added this to UCX Jun 27, 2025
@gueniai gueniai moved this to Ready for Review in UCX Jun 27, 2025
@pritishpai pritishpai force-pushed the feat/rerun_assessment branch from 1b33d5c to 336eec1 Compare June 30, 2025 18:02
@pritishpai pritishpai requested a review from FastLee July 1, 2025 20:47
FastLee
FastLee requested changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@FastLee FastLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  1. Add a CLI command to rerun assessment
  2. Add the named parameter to the workflow fixture and include in a test.

@pritishpai pritishpai force-pushed the feat/rerun_assessment branch from e4bfabc to a0e0325 Compare July 4, 2025 16:15
@pritishpai pritishpai requested a review from asnare July 9, 2025 14:37
@pritishpai pritishpai force-pushed the feat/rerun_assessment branch from ce539ab to f6f04d0 Compare July 17, 2025 14:17
pritishpai added 18 commits July 17, 2025 22:01
@pritishpai
Full refresh all crawlers for each assessment run
7703582
@pritishpai
Add documentation
841c0a0
@pritishpai
Make force_refresh of assessment parameter driven
e34525b
@pritishpai
Add a parameter to the assessment job for force_refresh of data
d532555
@pritishpai
Use set for membership test
bb55bf3
@pritishpai
Fetching permissions returns groups and users that have access.
2b9d42f
@pritishpai
Update readme to reflect parameter change
913edab
@pritishpai
Add force_refresh flag to ensure-assessment-run for full refresh of a…
8992380 
…ssessment
@pritishpai
Fetch flag value of force_refresh for assessment rerun
039a2bd
@pritishpai
Add integration test, fetch parameter from current job run
30752af
@pritishpai
Update cli command
3164a46
@pritishpai
Fix fmt
14280a4
@pritishpai
Add job_parameters to the test run_now to imitate adding it to run_wo…
d6a4d7f 
…rkflow
@pritishpai
Indicate job_parameters argument is intentionally unused
82c5602
@pritishpai
Fix error due to list to set comparison
be1342e
@pritishpai
Use set comprehension directly
3e3743d
@pritishpai
Fix unit tests and cli command
3745bca
@pritishpai
Update cli and docs
8237277
@pritishpai pritishpai force-pushed the feat/rerun_assessment branch from f6f04d0 to 8237277 Compare July 18, 2025 02:01
@pritishpai pritishpai requested a review from FastLee July 21, 2025 18:10
@pritishpai pritishpai deployed to account-admin July 21, 2025 18:10 — with GitHub Actions Active
@asnare asnare changed the title Added force_refresh parameter for Assessment Added force_refresh parameter for Assessment Jul 23, 2025
@asnare asnare added documentation Improvements or additions to documentation enhancement New feature or request step/assessment go/uc/upgrade - Assessment Step feat/migration-progress Issues related to the migration progress workflow labels Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asnare asnare Awaiting requested review from asnare

@FastLee FastLee Awaiting requested review from FastLee

Requested changes must be addressed to merge this pull request.

Assignees

@pritishpai pritishpai

Labels
documentation Improvements or additions to documentation enhancement New feature or request feat/migration-progress Issues related to the migration progress workflow step/assessment go/uc/upgrade - Assessment Step
Projects
UCX
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to rerun assessment by refreshing all data
3 participants
@pritishpai @FastLee @asnare