Skip to content

Unit test fix: test_cluster_remap_error (didn't fix it properly in #4030) #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

asnare
Copy link
Contributor

@asnare asnare commented May 16, 2025

Changes

One of the unit tests (test_cluster_remap_error) updated in #4030 wasn't done properly, and still wasn't capturing the logs in the right way. This PR fixes that.

Linked issues

Follows #4030.

Tests

  • manually tested (against blueprint@cli-missing-debug-logging)
  • updated unit test

@asnare asnare requested a review from FastLee May 16, 2025 14:31
@asnare asnare self-assigned this May 16, 2025
@asnare asnare requested a review from a team as a code owner May 16, 2025 14:32
@asnare asnare added this to UCX May 16, 2025
@asnare asnare added the internal this pull request won't appear in release notes label May 16, 2025
@asnare asnare temporarily deployed to account-admin May 16, 2025 14:32 — with GitHub Actions Inactive
@asnare asnare moved this to Ready for Review in UCX May 16, 2025
Copy link

✅ 2/2 passed, 20s total

Running from acceptance #8621

@asnare asnare enabled auto-merge May 16, 2025 14:34
Copy link
Contributor

@FastLee FastLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say so...

@asnare asnare added this pull request to the merge queue May 16, 2025
Merged via the queue into main with commit 8d0e018 May 16, 2025
8 checks passed
@asnare asnare deleted the update-caplog-tests branch May 16, 2025 14:41
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal this pull request won't appear in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants