Skip to content

Update the minimum version of databricks-labs-pytester to 0.7.2 #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025

Conversation

asnare
Copy link
Contributor

@asnare asnare commented May 14, 2025

The just released version of pytester includes a fix for a breaking change that was introduced by Databricks SDK 0.51: older versions of pytester will fail to import if the new Databricks SDK is present.

This PR updates the test dependency to the version that was just released:

  • This is mainly informational in terms of the breaking change: it doesn't affect user installs, and fresh development environments will probably pick up the newer version anyway.
  • The existing specified version is probably wrong: since 0.3.0 we've introduced things in pytester that ucx requires, but the dependency was not updated to reflect this.

The latest release is needed for current versions of the Databricks SDK. In addition, we almost certainly rely on things in the pytester library that were introduced after 0.3.0.
@asnare asnare self-assigned this May 14, 2025
@asnare asnare requested a review from a team as a code owner May 14, 2025 08:38
@asnare asnare added the dependencies Pull requests that update a dependency file label May 14, 2025
@asnare asnare added this to UCX May 14, 2025
@asnare asnare moved this to Ready for Review in UCX May 14, 2025
Copy link

github-actions bot commented May 14, 2025

✅ 2/2 passed, 24s total

Running from acceptance #8612

@asnare asnare moved this from Ready for Review to Blocked/Hold in UCX May 14, 2025
@asnare asnare added the pr/do-not-merge this pull request is not ready to merge label May 14, 2025
@asnare
Copy link
Contributor Author

asnare commented May 14, 2025

This can't be merged: the project is currently using an old version of the Databricks SDK and until that is updated (via: #4026 or similar) this PR itself should not be merged.

@asnare asnare temporarily deployed to account-admin May 14, 2025 18:14 — with GitHub Actions Inactive
@asnare asnare moved this from Blocked/Hold to Ready for Review in UCX May 14, 2025
@asnare asnare removed the pr/do-not-merge this pull request is not ready to merge label May 14, 2025
@asnare asnare requested review from FastLee and pritishpai May 14, 2025 18:22
@asnare asnare added the internal this pull request won't appear in release notes label May 14, 2025
@pritishpai pritishpai added this pull request to the merge queue May 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2025
@asnare asnare added this pull request to the merge queue May 15, 2025
Merged via the queue into main with commit 69f7f37 May 15, 2025
8 checks passed
@asnare asnare deleted the upgrade-labs-pytester branch May 15, 2025 16:59
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in UCX May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal this pull request won't appear in release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants