Skip to content

Conversation

WalBeh
Copy link
Contributor

@WalBeh WalBeh commented Sep 23, 2025

Summary of changes

dc_util does not work correctly on clusters with multiple sts (eg. like on the previously updated cluster where we added dedicated master nodes).

Checklist

  • Link to issue this PR refers to:
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@WalBeh WalBeh requested a review from tomach September 23, 2025 16:00
Copy link
Contributor

@tomach tomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work! maybe in the tests, it might be safer to call extractNodeName() directly instead of re-implementing the parsing logic? then the tests will break if the function ever changes unexpectedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants