improving giscus repo comment in _config.yml #2477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated comment next to giscus repo parameter to improve clarity that it should be the same repo as the github pages repo. otherwise you will get CSP errors and it won't load properly. Signed-off-by: Dolly Minx <github@dollyminx.com>
|
Thank you for your PR! However, I don't think the original comment needs to be changed. In fact, you can create a separate repository for storing Giscus comments for your site. If you have more questions, please refer to the documentation on https://giscus.app/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
updated comment next to giscus repo parameter to help others know that it should be the same repo as the github pages repo. otherwise you will get content security policy errors and it won't load properly.
I mistakenly was under the impression that you had to fork/clone the giscus repo into your personal repository, and use that instead, and wanted to hopefully help out someone else in case they had the same thought.
Additional context