Set secure file permissions (0600) for config.yaml files #7818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config files containing API keys and other sensitive data should not be world-readable. This PR changes the file creation mode to 0600 (owner read/write only) when creating or updating config.yaml files.
Changes:
getConfigYamlPath()
incore/util/paths.ts
to set mode 0600 when creating initial config.yamleditConfigYaml()
incore/util/paths.ts
to set mode 0600 when updating config.yamlextensions/vscode/src/commands.ts
to set mode 0600Security Impact:
This prevents accidentally exposing API keys and other credentials in config.yaml to other users on multi-user systems.
Summary by cubic
Set config.yaml permissions to 0600 (owner read/write only) when creating or updating the file in both core and VS Code extension paths. This prevents world-readable configs and reduces the risk of leaking API keys on multi-user systems.